Skip to content

Bugfix: MAX_ANGLE/MIN_ANGLE are 16-bit data fields on servo. #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2022
Merged

Bugfix: MAX_ANGLE/MIN_ANGLE are 16-bit data fields on servo. #25

merged 1 commit into from
Jan 17, 2022

Conversation

aentinger
Copy link
Contributor

Also the function 'angleToPosition' correctly return a uint16_t. Therefore the function 'writeWordCmd' needs to be used to write actual 2-Bytes/16-Bit, otherwise the 'L' part of the angle will be never written.

@aentinger
Bugfix: MAX_ANGLE/MIN_ANGLE are 16-bit data fields on servo.
5ab1fb5 
Also the function 'angleToPosition' correctly return a uint16_t. Therefore the function 'writeWordCmd' needs to be used to write actual 2-Bytes/16-Bit, otherwise the 'L' part of the angle will be never written.
@aentinger aentinger added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jan 14, 2022
@aentinger aentinger requested a review from facchinm January 14, 2022 10:18
@aentinger aentinger self-assigned this Jan 14, 2022
@github-actions
Copy link

Memory usage change @ 5ab1fb5

Board flash % RAM for global variables %
arduino:mbed_nano:nanorp2040connect 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/Braccio__Template
flash		 % examples/Braccio__Template
RAM for global variables		 % examples/Braccio_factory_setID_interactive
flash		 % examples/Braccio_factory_setID_interactive
RAM for global variables		 % examples/LCD_Custom_Menu
flash		 % examples/LCD_Custom_Menu
RAM for global variables		 % examples/LCD_Menu_Joystick
flash		 % examples/LCD_Menu_Joystick
RAM for global variables		 % examples/LCD_Motors
flash		 % examples/LCD_Motors
RAM for global variables		 % examples/LearnByDoing
flash		 % examples/LearnByDoing
RAM for global variables		 % examples/New_APIs
flash		 % examples/New_APIs
RAM for global variables		 % examples/Tools/Test_Inputs
flash		 % examples/Tools/Test_Inputs
RAM for global variables		 % examples/Tools/Test_Motor_Angular_Control
flash		 % examples/Tools/Test_Motor_Angular_Control
RAM for global variables		 % examples/Tools/Test_Motor_Communication
flash		 % examples/Tools/Test_Motor_Communication
RAM for global variables		 %
arduino:mbed_nano:nanorp2040connect 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV 
Board,examples/Braccio__Template<br>flash,%,examples/Braccio__Template<br>RAM for global variables,%,examples/Braccio_factory_setID_interactive<br>flash,%,examples/Braccio_factory_setID_interactive<br>RAM for global variables,%,examples/LCD_Custom_Menu<br>flash,%,examples/LCD_Custom_Menu<br>RAM for global variables,%,examples/LCD_Menu_Joystick<br>flash,%,examples/LCD_Menu_Joystick<br>RAM for global variables,%,examples/LCD_Motors<br>flash,%,examples/LCD_Motors<br>RAM for global variables,%,examples/LearnByDoing<br>flash,%,examples/LearnByDoing<br>RAM for global variables,%,examples/New_APIs<br>flash,%,examples/New_APIs<br>RAM for global variables,%,examples/Tools/Test_Inputs<br>flash,%,examples/Tools/Test_Inputs<br>RAM for global variables,%,examples/Tools/Test_Motor_Angular_Control<br>flash,%,examples/Tools/Test_Motor_Angular_Control<br>RAM for global variables,%,examples/Tools/Test_Motor_Communication<br>flash,%,examples/Tools/Test_Motor_Communication<br>RAM for global variables,%
arduino:mbed_nano:nanorp2040connect,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

@aentinger aentinger merged commit cb988f4 into master Jan 17, 2022
@aentinger aentinger deleted the fix-set-max/min-angle-wrong branch January 17, 2022 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facchinm facchinm Awaiting requested review from facchinm

Assignees

@aentinger aentinger

Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aentinger